test: add integration tests against Postgres.js #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hauleth
force-pushed
the
test/add-postgresjs-integration-tests
branch
from
f94e985 to
1ed6868
Compare
hauleth
changed the title
hauleth
force-pushed
the
test/add-postgresjs-integration-tests
branch
3 times, most recently
from
2279197 to
5903fbf
Compare
hauleth
force-pushed
the
test/add-postgresjs-integration-tests
branch
11 times, most recently
from
1826e32 to
f6d8907
Compare
hauleth
commented
Nov 14, 2024
| initialScript = '' | ||
| ${builtins.readFile ./dev/postgres/00-setup.sql} | ||
|
|
||
| CREATE USER postgres SUPERUSER PASSWORD 'postgres'; | ||
| ''; | ||
| listen_addresses = "127.0.0.1"; | ||
| port = 6432; | ||
| settings = { | ||
| max_prepared_transactions = 262143; |
There was a problem hiding this comment.
It is maximal possible value, in tests I have set it to 2000 as it doesn't matter really as long as it is greater than 0 I think.
abc3
reviewed
Nov 15, 2024
Comment on lines
+141
to
+142
| otp-version: '25.3.2.7' | ||
| elixir-version: '1.14.5' |
There was a problem hiding this comment.
wondering if we want to put these versions in the env vars
There was a problem hiding this comment.
Could be useful, but as a separate PR. There I simply copied what we have in other steps.
abc3
reviewed
Nov 15, 2024
Comment on lines
+1
to
+2
| 1 2 3 | ||
| 4 5 6 |
There was a problem hiding this comment.
No idea, it is copied as is from postgres.js test folder. I haven't really checked if that is used anywhere in test suite.
There was a problem hiding this comment.
let's try to run it without this file :D
There was a problem hiding this comment.
I have found that it is used in one test:
t('Copy from file', async() => {
await sql`create table test (x int, y int, z int)`
await new Promise(async r => fs
.createReadStream(rel('copy.csv'))
.pipe(await sql`copy test from stdin`.writable())
.on('finish', r)
)
return [
JSON.stringify(await sql`select * from test`),
'[{"x":1,"y":2,"z":3},{"x":4,"y":5,"z":6}]',
await sql`drop table test`
]
})
hauleth
force-pushed
the
test/add-postgresjs-integration-tests
branch
from
f6d8907 to
458fc9d
Compare
abc3
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Add integration tests against Postgres.js Node library.